Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi): remove summary field under Info #3178

Merged
merged 2 commits into from Nov 3, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Nov 2, 2022

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner November 2, 2022 14:48
@aarnphm aarnphm requested review from bojiang and removed request for a team November 2, 2022 14:48
@aarnphm aarnphm changed the title fix: remove summary field under Info object fix(openapi): remove summary field under Info Nov 2, 2022
@aarnphm aarnphm enabled auto-merge (squash) November 2, 2022 14:48
@aarnphm aarnphm requested a review from sauyon November 2, 2022 14:48
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3178 (43fde18) into main (3193102) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
- Coverage   21.71%   21.64%   -0.08%     
==========================================
  Files         101      101              
  Lines        9721     9734      +13     
  Branches     1688     1691       +3     
==========================================
- Hits         2111     2107       -4     
- Misses       7562     7578      +16     
- Partials       48       49       +1     
Impacted Files Coverage Δ
src/bentoml/_internal/service/openapi/__init__.py 68.75% <ø> (ø)
...bentoml/_internal/service/openapi/specification.py 90.56% <ø> (-0.05%) ⬇️
src/bentoml/_internal/monitoring/api.py 40.54% <0.00%> (-2.85%) ⬇️
src/bentoml/_internal/configuration/__init__.py 53.16% <0.00%> (-2.54%) ⬇️
src/bentoml/_internal/utils/__init__.py 24.36% <0.00%> (-0.73%) ⬇️
src/bentoml/_internal/log.py 0.00% <0.00%> (ø)

@aarnphm aarnphm merged commit 5d14f6e into bentoml:main Nov 3, 2022
@aarnphm aarnphm deleted the fix/openapi-spec branch November 3, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: BentoML generated OpenAPI differs from Speci
2 participants